Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type column to scan config to allow filter and sort by type #1331

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Add type column to scan config to allow filter and sort by type #1331

merged 3 commits into from
Apr 29, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review April 29, 2019 09:40
@sarahd93 sarahd93 requested a review from a team April 29, 2019 09:40
@codecov
Copy link

codecov bot commented Apr 29, 2019 •
edited
Loading

Codecov Report

Merging #1331 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1331      +/-   ##
==========================================
- Coverage    34.41%   34.4%   -0.01%     
==========================================
  Files          959     959              
  Lines        21579   21584       +5     
  Branches      5972    5954      -18     
==========================================
+ Hits          7426    7427       +1     
- Misses       12799   12802       +3     
- Partials      1354    1355       +1
Impacted Files Coverage Δ
gsa/src/web/pages/scanconfigs/row.js 50% <ø> (ø) ⬆️
gsa/src/web/pages/scanconfigs/table.js 100% <ø> (ø) ⬆️
gsa/src/web/pages/scanconfigs/header.js 13.33% <0%> (-0.96%) ⬇️
gsa/src/gmp/models/scanconfig.js 95.31% <25%> (-4.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bdceb...0b3a676. Read the comment docs.

@bjoernricks bjoernricks merged commit d1602f3 into greenbone:gsa-8.0 Apr 29, 2019
@sarahd93 sarahd93 deleted the scan_config_gsa8 branch April 29, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahd93 @bjoernricks